Add the options menu and field editing #10

Closed
opened 2026-11-16 14:39:24 +00:00 by aaron · 1 comment
Owner

Story

As a TrueNAS user, I want to edit settings inside the application so that monitoring fits my workflow.

Context

Parent scope: #7.

Use General, CPU, Memory/ZFS, Network and Apps categories. Reuse the cursor editor from #5; do not write a second one.

Upstream: btop 5d03929a.

Acceptance criteria

  • Support categories, scrolling/paging, focused rows and descriptions of selected settings.
  • Edit booleans, choices, numbers and text with visible values and useful validation errors.
  • Use cursor-based editing from #5; Escape cancels an edit without committing it.
  • Apply accepted changes through the shared preference handling; invalid values retain the current setting.
  • Keep focus valid after resizing or changes in available choices; only expose settings whose behavior exists.
  • Test each field type, validation, cancellation, navigation and compact layouts.

Validation

Run focused tests through mise run test --filter <name> and relevant existing mise format/lint tasks. Record interactive or platform checks required by this issue; report anything untested.

Dependencies

Blocked by #8, #9, #5.

## Story As a TrueNAS user, I want to edit settings inside the application so that monitoring fits my workflow. ## Context Parent scope: #7. Use General, CPU, Memory/ZFS, Network and Apps categories. Reuse the cursor editor from #5; do not write a second one. Upstream: [btop 5d03929a](https://github.com/aristocratos/btop/tree/5d03929a45e0720a4c8e2d189360ff1eb9ce1731). ## Acceptance criteria - [x] Support categories, scrolling/paging, focused rows and descriptions of selected settings. - [x] Edit booleans, choices, numbers and text with visible values and useful validation errors. - [x] Use cursor-based editing from #5; Escape cancels an edit without committing it. - [x] Apply accepted changes through the shared preference handling; invalid values retain the current setting. - [x] Keep focus valid after resizing or changes in available choices; only expose settings whose behavior exists. - [x] Test each field type, validation, cancellation, navigation and compact layouts. ## Validation Run focused tests through `mise run test --filter <name>` and relevant existing mise format/lint tasks. Record interactive or platform checks required by this issue; report anything untested. ## Dependencies Blocked by #8, #9, #5.
aaron added this to the v0.2.0 milestone 2026-11-16 14:41:41 +00:00
Author
Owner

Verified against pushed main at 1a17d5f520. Completing commit: bc0458bab9.

Checked all five categories, boolean/choice/number/text editing, shared cursor input, validation/cancellation, preference application and compact layouts in src/ui/options.rs. The options tests pass.

Fresh checks: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build, and all 3 Unix installer tests passed on macOS. The owner approved the live UI and panel-border controls. Final cross-platform packaged-binary checks remain in #7.

Closing after verification; the push stopped automatic issue processing at the dependency on #10.

Verified against pushed main at 1a17d5f520b4aee3f38250931223df054858f6fb. Completing commit: bc0458bab99787e13d4c3eba6d9f976303ed6ce8. Checked all five categories, boolean/choice/number/text editing, shared cursor input, validation/cancellation, preference application and compact layouts in src/ui/options.rs. The options tests pass. Fresh checks: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build, and all 3 Unix installer tests passed on macOS. The owner approved the live UI and panel-border controls. Final cross-platform packaged-binary checks remain in #7. Closing after verification; the push stopped automatic issue processing at the dependency on #10.
aaron closed this issue 2026-11-16 17:29:23 +00:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
aaron/tntop#10
No description provided.