Embed and discover bundled and user themes #15
Labels
No labels
build
client
config
presets
priority
p0
priority
p1
priority
p2
priority
p3
priority
p4
state
blocked
state
in progress
state
triage
theming
type
bug
type
chore
type
enhancement
type
fix
type
optimization
type
release
type
spec
ui
ux
No assignees
1 participant
Notifications
Due date
No due date set.
Blocks
Depends on
#13 Vendor the complete btop theme folder
aaron/tntop
#14 Support the bundled btop theme palettes
aaron/tntop
Reference
aaron/tntop#15
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Story
As a TrueNAS user, I want to select themes without managing installation folders so that monitoring fits my workflow.
Context
Parent scope: #7.
Embed themes for offline use. Cargo.toml currently includes src/**, README.md and LICENSE only, so source packaging must include theme inputs too.
Upstream: btop 5d03929a.
Acceptance criteria
Validation
Run focused tests through
mise run test --filter <name>and relevant existing mise format/lint tasks. Record interactive or platform checks required by this issue; report anything untested.Dependencies
Blocked by #13, #14.
Verified against pushed main at
1a17d5f520. Completing commit:1ea1b9b9ad.Checked unconditional compile-time embedding with include_str! and the complete catalog in src/ui/theme.rs. Cargo source packaging includes all 49 themes and their license. A copied macOS binary outside the checkout loaded every bundled theme plus Default and TTY, with no theme files beside it; all 51 runs exited cleanly and restored terminal state. Discovery, collisions, explicit paths and directory-error tests pass. Native Linux/Windows packaged-binary smoke checks remain tracked by #7; this closure records the completed embedding implementation, not those unperformed checks.
Fresh checks: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build, and all 3 Unix installer tests passed on macOS. The owner approved the live UI and panel-border controls. Final cross-platform packaged-binary checks remain in #7.
Closing after verification; the push stopped automatic issue processing at the dependency on #10.