Specify btop menu, preset and theme adaptation #7
Labels
No labels
build
client
config
presets
priority
p0
priority
p1
priority
p2
priority
p3
priority
p4
state
blocked
state
in progress
state
triage
theming
type
bug
type
chore
type
enhancement
type
fix
type
optimization
type
release
type
spec
ui
ux
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
aaron/tntop#7
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Story
As a TrueNAS user, I want btop-style menus, presets and themes so that I can customize tntop without editing configuration by hand.
Context
This is the approved scope and tracking issue. Reference btop at 5d03929a, especially src/btop_menu.cpp, src/btop_config.cpp, src/btop_input.cpp and themes/.
Adapt btop to the data tntop already collects. The owner chose TrueNAS adaptation rather than full btop parity.
Menus and controls
Deliver Main, Options, Help, message and terminal-size handling, with keyboard and mouse support. Main offers Options, Help, Servers and Quit. Options has General, CPU, Memory/ZFS, Network and Apps categories. Storage stays within Memory/ZFS.
Use m/Esc for Main, F2/o for Options, F1/?/h for Help, p/P for next/previous preset and 1-4 for panel toggles. Keep s for Servers. Move app sorting to Left/Right and pool selection to [ and ]. In Vim mode, H opens Help when h navigates. Text editing consumes keys first; Escape closes one active layer and Ctrl-C exits.
Presets and themes
Use cpu, mem, net and apps panels; accept btop's proc name as an alias for apps. Preset 0 shows all four. Adapt all three upstream default presets and allow up to nine configured presets with alternate positions and per-panel graph styles.
Vendor all 49 upstream .theme files from the pinned commit with author notices and the Apache-2.0 license. Embed the catalog in release binaries so themes work offline without a separate installation step. Preserve explicit theme paths and discover user themes under the tntop configuration themes directory, with documented name precedence.
Option coverage
Exclusions
No new telemetry or remote control APIs. Exclude raw process lists, signals, renice, trees/aggregation, PID/user/thread/kernel filters, dead-process accounting and app start/stop/restart. Exclude GPU, battery/UPS, CPU frequency/wattage, sensor selection/remapping, swap, mount/fstab filters, dataset hiding and privileged free-space controls. Document these differences instead of exposing settings that do nothing.
Existing issues
Reuse #1 (black background), #2 (purple title) and #5 (cursor editing), without duplicate issues. Embedded themes mean #4 (installer) and #6 (self-update) do not need to copy theme folders.
Acceptance criteria
The scope is approved. This parent tracks delivery and stays open until completion; it is not an unfinished blocker for its children.
Delivery order
Start with preferences, main-menu input, theme vendoring, graph styles and layout, plus existing #1/#2/#5. Options features follow the editor. Preset activation follows layout, graph and parser work. Theme and preset work can proceed independently. Each feature includes its own tests and mouse/help integration. Native dependency links record unfinished prerequisites.
Implementation issues
Verified the pushed implementation at
1a17d5f520and closed the 20 remaining feature issues with individual evidence. All child implementation issues #8-#30 are now closed.Fresh macOS checks passed: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build and 3 Unix installer tests. All 49 themes and the license match the pinned upstream archive byte for byte, and Cargo source packaging contains them. A copied binary outside the checkout loaded all 49 bundled themes plus Default/TTY with no theme folder; all 51 PTY runs exited cleanly and restored terminal state. The owner already approved the live UI and embedded controls.
Keeping this delivery issue open for final packaged-binary verification on Linux and Windows. Those runtime checks have not run on this implementation. The Linux CI run for this push was still running when checked. Version remains 0.1.0; no 0.2.0 release has occurred.