Add live theme selection and background control #16

Closed
opened 2026-11-16 14:39:26 +00:00 by aaron · 1 comment
Owner

Story

As a TrueNAS user, I want to preview a theme and choose its background behavior so that monitoring fits my workflow.

Context

Parent scope: #7.

Use the catalog and options editor. Coordinate with existing #1 and #2 instead of duplicating the default black background or purple title fixes.

Upstream: btop 5d03929a.

Acceptance criteria

  • List built-in, bundled and user themes in Options.
  • Preview a selection across menus and panels without restarting or clearing metrics.
  • Commit/cancel selection and persist accepted choices through shared preferences.
  • Provide theme_background to switch between theme and terminal backgrounds.
  • Keep the current valid theme on a load failure and display a useful error.
  • Test preview, cancellation, save, invalid files and interaction with #1 and #2.

Validation

Run focused tests through mise run test --filter <name> and relevant existing mise format/lint tasks. Record interactive or platform checks required by this issue; report anything untested.

Dependencies

Blocked by #10, #15.

## Story As a TrueNAS user, I want to preview a theme and choose its background behavior so that monitoring fits my workflow. ## Context Parent scope: #7. Use the catalog and options editor. Coordinate with existing #1 and #2 instead of duplicating the default black background or purple title fixes. Upstream: [btop 5d03929a](https://github.com/aristocratos/btop/tree/5d03929a45e0720a4c8e2d189360ff1eb9ce1731). ## Acceptance criteria - [x] List built-in, bundled and user themes in Options. - [x] Preview a selection across menus and panels without restarting or clearing metrics. - [x] Commit/cancel selection and persist accepted choices through shared preferences. - [x] Provide theme_background to switch between theme and terminal backgrounds. - [x] Keep the current valid theme on a load failure and display a useful error. - [x] Test preview, cancellation, save, invalid files and interaction with #1 and #2. ## Validation Run focused tests through `mise run test --filter <name>` and relevant existing mise format/lint tasks. Record interactive or platform checks required by this issue; report anything untested. ## Dependencies Blocked by #10, #15.
aaron added this to the v0.2.0 milestone 2026-11-16 14:41:41 +00:00
Author
Owner

Verified against pushed main at 1a17d5f520. Completing commit: afb51a625c.

Checked theme catalog preview, accept/cancel, persistence, background switching and load-error handling in src/ui/options.rs and src/ui/theme.rs. Tests verify retained sessions and the current valid theme on failed loads.

Fresh checks: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build, and all 3 Unix installer tests passed on macOS. The owner approved the live UI and panel-border controls. Final cross-platform packaged-binary checks remain in #7.

Closing after verification; the push stopped automatic issue processing at the dependency on #10.

Verified against pushed main at 1a17d5f520b4aee3f38250931223df054858f6fb. Completing commit: afb51a625c961948c3ad961f155610938a0c2cbe. Checked theme catalog preview, accept/cancel, persistence, background switching and load-error handling in src/ui/options.rs and src/ui/theme.rs. Tests verify retained sessions and the current valid theme on failed loads. Fresh checks: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build, and all 3 Unix installer tests passed on macOS. The owner approved the live UI and panel-border controls. Final cross-platform packaged-binary checks remain in #7. Closing after verification; the push stopped automatic issue processing at the dependency on #10.
aaron closed this issue 2026-11-16 17:29:28 +00:00
Sign in to join this conversation.
No description provided.