Support the bundled btop theme palettes #14

Closed
opened 2026-11-16 14:39:25 +00:00 by aaron · 1 comment
Owner

Story

As a TrueNAS user, I want to see themes applied consistently to menus and panels so that monitoring fits my workflow.

Context

Parent scope: #7.

Extend the parser in src/ui/theme.rs for the palette roles used by tntop, retaining harmless unknown-key handling.

Upstream: btop 5d03929a.

Acceptance criteria

  • Parse every vendored theme and support menu, selection, meter, border, text and graph palette roles used by the UI.
  • Preserve RGB/hex values, optional empty gradient stops and explicit terminal-background values.
  • Provide consistent fallbacks for missing colors without breaking existing custom themes.
  • Malformed supported values produce useful errors without panic or partly replacing the active theme.
  • Test all 49 files, sparse themes, malformed values and gradient fallbacks.

Validation

Run focused tests through mise run test --filter <name> and relevant existing mise format/lint tasks. Record interactive or platform checks required by this issue; report anything untested.

Dependencies

Blocked by #13.

## Story As a TrueNAS user, I want to see themes applied consistently to menus and panels so that monitoring fits my workflow. ## Context Parent scope: #7. Extend the parser in src/ui/theme.rs for the palette roles used by tntop, retaining harmless unknown-key handling. Upstream: [btop 5d03929a](https://github.com/aristocratos/btop/tree/5d03929a45e0720a4c8e2d189360ff1eb9ce1731). ## Acceptance criteria - [x] Parse every vendored theme and support menu, selection, meter, border, text and graph palette roles used by the UI. - [x] Preserve RGB/hex values, optional empty gradient stops and explicit terminal-background values. - [x] Provide consistent fallbacks for missing colors without breaking existing custom themes. - [x] Malformed supported values produce useful errors without panic or partly replacing the active theme. - [x] Test all 49 files, sparse themes, malformed values and gradient fallbacks. ## Validation Run focused tests through `mise run test --filter <name>` and relevant existing mise format/lint tasks. Record interactive or platform checks required by this issue; report anything untested. ## Dependencies Blocked by #13.
aaron added this to the v0.2.0 milestone 2026-11-16 14:41:41 +00:00
Author
Owner

Verified against pushed main at 1a17d5f520. Completing commit: 5076dbd0a2.

Checked palette parsing and fallbacks in src/ui/theme.rs. Tests pass for all 49 themes, sparse palettes, optional gradient stops, terminal backgrounds and malformed values.

Fresh checks: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build, and all 3 Unix installer tests passed on macOS. The owner approved the live UI and panel-border controls. Final cross-platform packaged-binary checks remain in #7.

Closing after verification; the push stopped automatic issue processing at the dependency on #10.

Verified against pushed main at 1a17d5f520b4aee3f38250931223df054858f6fb. Completing commit: 5076dbd0a22efd37b5c5425d04e35d3c7e7d0c38. Checked palette parsing and fallbacks in src/ui/theme.rs. Tests pass for all 49 themes, sparse palettes, optional gradient stops, terminal backgrounds and malformed values. Fresh checks: all 103 Rust/CLI tests, all lint tasks, all-target/all-feature compilation, build, and all 3 Unix installer tests passed on macOS. The owner approved the live UI and panel-border controls. Final cross-platform packaged-binary checks remain in #7. Closing after verification; the push stopped automatic issue processing at the dependency on #10.
aaron closed this issue 2026-11-16 17:29:14 +00:00
Sign in to join this conversation.
No description provided.